fix(std/net/http): correct server lifecycle #1478

jay · 2026-08-05T04:57:57Z

jay commented

2026-08-05 04:57:57 +00:00

HTTP server shutdown can hang because listener EBADF errors are retried and condition-variable timeout results are ignored. Peer disconnects during server-owned response closing are also logged as unhandled handler failures.

This PR makes EBADF terminal, enforces the shutdown deadline, caches listener addresses before closure, and contains only EPIPE/ECONNRESET from response finalization.

HTTP server shutdown can hang because listener `EBADF` errors are retried and condition-variable timeout results are ignored. Peer disconnects during server-owned response closing are also logged as unhandled handler failures. This PR makes `EBADF` terminal, enforces the shutdown deadline, caches listener addresses before closure, and contains only `EPIPE`/`ECONNRESET` from response finalization.

jay added 1 commit

2026-08-05 04:57:57 +00:00

fix(std/net/http): correct server lifecycle 207d96b4f5

vyzo approved these changes

2026-08-31 13:55:56 +00:00

Dismissed

vyzo left a comment

this looks good to me, only actionable is to log the error when we fail to start a listener.

also, if all listeners fail i think we should fail the start altogether.

this looks good to me, only actionable is to log the error when we fail to start a listener. also, if all listeners fail i think we should fail the start altogether.

src/std/net/http/server/server.ss

					
				@ -70,2 +70,4 @@

				(def (do-server-start! (self : http-server))

				  => :void

				  (def (start-listener! (sock : ServerSocket))

				    (with-error (ignore-errors (sock.close))

i think that at the minimum report errors -- you can use report-errors

i think that at the minimum report errors -- you can use `report-errors`

although i think it is better to log the errors in the syslog instead of the console. so a try/catch and a syslog.error is in order.

👍 1

src/std/net/http/server/server.ss Outdated

					
				@ -180,3 +184,1 @@

				                    error: (OSError-message e)

				                    errno: (OSError-errno e))

				       (loop))

				       (if (fx= (OSError-errno e) EBADF)