net/address: add tests and fix parsing edge cases #1472

HMarcien · 2026-06-30T17:12:52Z

HMarcien commented

2026-06-30 17:12:52 +00:00

No description provided.

HMarcien added 1 commit

2026-06-30 17:12:52 +00:00

net/address: add tests and fix parsing edge cases 2c1fa7df32

HMarcien requested reviews from vyzo, fare

2026-06-30 17:13:42 +00:00

vyzo reviewed

2026-07-02 23:04:13 +00:00

vyzo left a comment

looks good, just a small question.

src/std/net/address/parser.ss

					
				@ -259,3 +255,1 @@

				                (raise-bad-argument string->address "unknown domain" addr))))))

				      (else

				       (raise-bad-argument string->address "not a canonical address" addr)))

				  (: (let (addr (string-trim addr))

is the trim really necessary? Shouldn't it be the responsibility of the caller?

This pull request has changes conflicting with the target branch.

src/std/net/address/parser.ss

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'net/address: add tests and fix parsing edge cases' (#1472) from hmarcien/test-address into v0.19-staging

Merge commit body

Reviewed-on: https://git.cons.io/mighty-gerbils/gerbil/pulls/1472

Merge pull request 'net/address: add tests and fix parsing edge cases' (#1472) from hmarcien/test-address into v0.19-staging

Reviewed-on: https://git.cons.io/mighty-gerbils/gerbil/pulls/1472

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin +refs/pull/1472/head:hmarcien/test-address

git switch hmarcien/test-address

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch v0.19-staging

git merge --no-ff hmarcien/test-address

git switch hmarcien/test-address

git rebase v0.19-staging

git switch v0.19-staging

git merge --ff-only hmarcien/test-address

git switch hmarcien/test-address

git rebase v0.19-staging

git switch v0.19-staging

git merge --no-ff hmarcien/test-address

git switch v0.19-staging

git merge --squash hmarcien/test-address