v0.19-fixes #1470
No reviewers
Labels
No labels
UX
active development
backlog
blocker
bootstrap
bounty
bug
dependencies
discussion
documentation
duplicate
enhancement
flaky test
help wanted
invalid
javascript
question
release
tendentious
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
mighty-gerbils/gerbil!1470
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "v0.19-fixes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
claude has a tendency to make a mess for no reason, please reign on it.
@ -1,6 +1,7 @@#!/bin/shset -eucd $(dirname "$0") # Change to this directory: ${__ORIG_PWD=$PWD}wtf
@ -2,2 +2,3 @@set -eucd $(dirname "$0") # Change to this directory: ${__ORIG_PWD=$PWD}cd "$(dirname "$0")" # Change to this directorywtf 2.
@ -74,3 +75,1 @@if [ "x${GERBIL_BUILD_CORES:-}" != "x" ]; thenecho "--- using ${GERBIL_BUILD_CORES} cores for the build"finotify_cores() {why is this an improvement?
So we can have a ./build.sh run that doesn't change the PWD and doesn't print "using 8 cores", and so ./build.sh run gxi can be used in a script as a regular gxi.
ugh, i dont think i like this idea.
@ -116,6 +116,7 @@ namespace: #fflags ; type-flags__table::t ; type-superfields ; type-fields;; TODO: fix the MOP so we can include __table::t in the precedence-listno, this won't happen.
please remove this todo.
I'd like to make it happen as part of our MOP: full support for Gambit structures as supers for our classes. Shouldn't be too hard: if it's a Gambit struct, use a table to find a Gerbil-like descriptor to substitute to it to find the missing slots.
no, i dont think it should happen.
gambit structs are already integrated with shadow classes, i dont want to mix the two hierarchies at all.
it will make life miserable as we'll have to check the type type everywhere.
so no, please untodo.
@ -165,3 +170,1 @@(&raw-table-test tab)(&raw-table-seed tab)(and (&raw-table-lock tab) (__make-inline-lock))))(let* ((size (raw-table-size-hint->size size-hint))wtf. why did it inline this?
@ -637,2 +647,3 @@(def (gc-table-new tab (size-hint #f))(##structure (##structure-type tab) (table-new (&gc-table-gcht tab) size-hint) #f))(##structure (##structure-type tab)(__gc-table-new (if (fixnum? size-hint) size-hint 16)here too.
@ -705,3 +705,1 @@(char : :char)(start :~ nonnegative-fixnum? :- :fixnum := 0))(let ((len (string-length str)))criterionplease provide 2 specialized versions for the criterion case and dispatch to them, as we discussed.
in fact, i think it is better to drop this from this pr.
it is not a fix, it is an arbitrary behavioral change.
@ -718,3 +729,1 @@(let* ((len (string-length str))(start (if (fixnum? start) start (fx- len 1))))(let lp ((k start))criterionsame here.
@ -43,0 +44,4 @@;; In the large-write-unbuffered path (bio.whi==0, want>=buflen) bio.whi;; is never advanced by __bio-write, so we must do it here or;; get-memory-output-* will read zero bytes.(set! mem.whi input-size)this blurb comment is just unnecessary, it is obvious why.
please remove it.
1c03237189to17ad18a5950bf66475cdtoafe807d8a1afe807d8a1to4d663480b0you have subtly changed the semantics of end in string-rindex, probably broken some code.
also, you have probably broken all the rules in build.sh with the change of staying out of dir. please don't.
@ -1,6 +1,6 @@#!/bin/shset -ecd $(dirname "$0")DIR="$(dirname "$0")"I don't like this change at all, you are breaking all my workflows.
also bootstrap build is broken now.
@ -724,2 +741,2 @@k(lp (fx- k 1))))))))criterion(end :? :fixnum := #f)just this to string-length... -1
@ -726,0 +742,4 @@(end :? :fixnum := #f)(start :~ nonnegative-fixnum? :- :fixnum := 0))(cond((not end) (set! end (string-length str)))that looks like an off by 1.
@ -726,0 +744,4 @@(cond((not end) (set! end (string-length str)))((not (and (nonnegative-fixnum? end) (fx<= end (string-length str))))(error "invalid end for string-index" str end)))you can raise-contract-violation-error here, please don't naked error
@ -726,0 +755,4 @@(char :- :char)(start :- :fixnum)(end :- :fixnum))(let lp ((k (fx- end 1)))that's semantics breaking.
4d663480b0to9bdb00f83bView command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.