mighty-gerbils/gerbil
mighty-gerbils/gerbil
6
1
Fork 1
Code Issues 135 Pull requests 4 Projects Releases Wiki Activity

replace u8vector port with direct buffer allocation #1464

Merged
vyzo merged 2 commits from hmarcien/1462-optimize-uri-decode into v0.19-staging 2026-06-13 18:30:15 +00:00 AGit
Conversation 2 Commits 2 Files changed 1 +24 -23
HMarcien commented 2026-06-13 15:25:45 +00:00
Member
Copy link

closes #1462

closes #1462
HMarcien requested review from vyzo 2026-06-13 16:18:26 +00:00
vyzo requested changes 2026-06-13 17:19:34 +00:00
Dismissed
vyzo left a comment
Copy link

just a small change to avoid an allocation, looks good otherwise and should be significantly faster.

just a small change to avoid an allocation, looks good otherwise and should be significantly faster.
src/std/net/uri.ss
@ -135,0 +132,4 @@
(##u8vector-set! u8-buffer j next)
(loop (fx+ i 1) (fx+ j 1)))))
(utf8->string (subu8vector u8-buffer 0 j))))))
vyzo commented 2026-06-13 17:19:00 +00:00
Owner
Copy link

you don't need to subu8vector, you can pass start end args to utf8->string and avoid the allocation.

you don't need to subu8vector, you can pass start end args to utf8->string and avoid the allocation.
HMarcien marked this conversation as resolved
HMarcien requested review from vyzo 2026-06-13 18:17:19 +00:00
vyzo approved these changes 2026-06-13 18:30:03 +00:00
vyzo left a comment
Copy link

thank you!

thank you!
vyzo merged commit 880bf1c583 into v0.19-staging 2026-06-13 18:30:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
vyzo
Labels
Clear labels   
UX

   
active development

   
backlog

   
blocker

   
bootstrap

   
bounty

   
bug

   
dependencies
Pull requests that update a dependency file

  
discussion

   
documentation

   
duplicate

   
enhancement

   
flaky test

   
help wanted

   
invalid

   
javascript
Pull requests that update javascript code

  
question

   
release

   
tendentious

   
wontfix
No labels
UX
active development
backlog
blocker
bootstrap
bounty
bug
dependencies
discussion
documentation
duplicate
enhancement
flaky test
help wanted
invalid
javascript
question
release
tendentious
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mighty-gerbils/gerbil!1464
No description provided.