fix(net/uri) fix issues and add tests #1461
No reviewers
Labels
No labels
UX
active development
backlog
blocker
bootstrap
bounty
bug
dependencies
discussion
documentation
duplicate
enhancement
flaky test
help wanted
invalid
javascript
question
release
tendentious
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
mighty-gerbils/gerbil!1461
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "hmarcien/fix-net-uri-and-tests"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
remove unused importto fix(net/uri) fix issues and add teststhank you, lgtm!
left a comment about a possible performance improvement, but we dont have to do it now; a TODO is fine.
@ -132,2 +111,2 @@(write-u8 next)(loop (fx+ i 1)))))))))))(pct (char->integer #\%))(utf8 (with-output-to-u8vectorugh, string doesnt let you write bytes...
it would probably be more efficient to just collect the bytes and make a u8vector at the end now that i think about it.
non-binding, we can leave it for later but probably needs a TODO.
follow up issue in #1462