v0.19 serde format #1434

Merged
vyzo merged 11 commits from v0.19-serde-format into v0.19-staging 2026-05-22 09:46:51 +00:00
Owner

implement format as generic serde serializer

implement format as generic serde serializer
fare left a comment

Looks generally good. Two small remarks.

Looks generally good. Two small remarks.
@ -72,0 +541,4 @@
(do-write (wr wr)
(if space?
(env.methods.write-delimiter writer env)
0)
Owner

Why the 0 here?

Why the 0 here?
Author
Owner

wrote 0 bytes for the do-write monad

wrote 0 bytes for the do-write monad
fare marked this conversation as resolved
@ -72,0 +576,4 @@
(env.methods.write-object-begin writer env)
(writer.write-object-type procedure::t env)
(env.methods.write-delimiter writer env)
(writer.serialize (##procedure-name proc) env)
Owner

Is there always a name? What if there is not? What if it's not a global name? Do we also get an "address" or some other uniquely-identifying information?

Is there always a name? What if there is not? What if it's not a global name? Do we also get an "address" or some other uniquely-identifying information?
Author
Owner

there is not always a name. We are foing to have to circle back at this, not sure what we can do.

there is not always a name. We are foing to have to circle back at this, not sure what we can do.
Owner

OK, making it easier to name procedures should be a different PR, but we need to offer primitives for that.

CL has a print-unreadable-object macro to help with such situations: http://www.ai.mit.edu/projects/iiip/doc/CommonLISP/HyperSpec/Body/mac_print-unr_dable-object.html
mind the type and identity flags.

OK, making it easier to name procedures should be a different PR, but we need to offer primitives for that. CL has a print-unreadable-object macro to help with such situations: http://www.ai.mit.edu/projects/iiip/doc/CommonLISP/HyperSpec/Body/mac_print-unr_dable-object.html mind the type and identity flags.
Author
Owner

lets make an issue for this, it needs to be discussed.

lets make an issue for this, it needs to be discussed.
Owner

LGTM generally, but a few small questions.

LGTM generally, but a few small questions.
vyzo merged commit 32a91aae02 into v0.19-staging 2026-05-22 09:46:51 +00:00
vyzo referenced this pull request from a commit 2026-05-22 09:46:52 +00:00
vyzo deleted branch v0.19-serde-format 2026-05-22 09:47:36 +00:00
fare referenced this pull request from a commit 2026-06-04 09:50:19 +00:00
Sign in to join this conversation.
No description provided.