v0.19 serde format #1434
No reviewers
Labels
No labels
UX
active development
backlog
blocker
bootstrap
bounty
bug
dependencies
discussion
documentation
duplicate
enhancement
flaky test
help wanted
invalid
javascript
question
release
tendentious
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
mighty-gerbils/gerbil!1434
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "v0.19-serde-format"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
implement format as generic serde serializer
Looks generally good. Two small remarks.
@ -72,0 +541,4 @@(do-write (wr wr)(if space?(env.methods.write-delimiter writer env)0)Why the 0 here?
wrote 0 bytes for the do-write monad
@ -72,0 +576,4 @@(env.methods.write-object-begin writer env)(writer.write-object-type procedure::t env)(env.methods.write-delimiter writer env)(writer.serialize (##procedure-name proc) env)Is there always a name? What if there is not? What if it's not a global name? Do we also get an "address" or some other uniquely-identifying information?
there is not always a name. We are foing to have to circle back at this, not sure what we can do.
OK, making it easier to name procedures should be a different PR, but we need to offer primitives for that.
CL has a print-unreadable-object macro to help with such situations: http://www.ai.mit.edu/projects/iiip/doc/CommonLISP/HyperSpec/Body/mac_print-unr_dable-object.html
mind the type and identity flags.
lets make an issue for this, it needs to be discussed.
LGTM generally, but a few small questions.